Messages in this thread | | | Date | Sun, 11 Nov 2018 12:31:03 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH v5 04/27] x86/fpu/xstate: Add XSAVES system states for shadow stack |
| |
Hi!
> > +/* > > + * State component 12 is Control flow Enforcement kernel states > > + */ > > +struct cet_kernel_state { > > + u64 kernel_ssp; /* kernel shadow stack */ > > + u64 pl1_ssp; /* ring-1 shadow stack */ > > + u64 pl2_ssp; /* ring-2 shadow stack */ > > Just write "privilege level" everywhere - not "ring".
Please just use word "ring". It is well estabilished terminology.
Which ring is priviledge level 1, given that we have SMM and virtualization support?
Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |