lkml.org 
[lkml]   [2018]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 1/3] mfd: upboard: Add UP2 platform controller driver
    Hi!

    > +static void __reg_io_start(const struct upboard_ddata * const ddata)
    > +{
    > + /*
    > + * CLEAR signal must be pulsed low before any register access.
    > + * This resets internal counters in the controller and marks
    > + * the start of a new register access.
    > + */
    > + set_clear(ddata, 0);
    > + set_clear(ddata, 1);
    > +}

    We normally reserve __ prefix for different stuff. This is not using
    it appropriately.
    Pavel

    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2018-11-11 12:30    [W:4.210 / U:0.596 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site