lkml.org 
[lkml]   [2018]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [mm PATCH v5 0/7] Deferred page init improvements
    On 18-11-05 13:19:25, Alexander Duyck wrote:
    > This patchset is essentially a refactor of the page initialization logic
    > that is meant to provide for better code reuse while providing a
    > significant improvement in deferred page initialization performance.
    >
    > In my testing on an x86_64 system with 384GB of RAM and 3TB of persistent
    > memory per node I have seen the following. In the case of regular memory
    > initialization the deferred init time was decreased from 3.75s to 1.06s on
    > average. For the persistent memory the initialization time dropped from
    > 24.17s to 19.12s on average. This amounts to a 253% improvement for the
    > deferred memory initialization performance, and a 26% improvement in the
    > persistent memory initialization performance.

    Hi Alex,

    Please try to run your persistent memory init experiment with Daniel's
    patches:

    https://lore.kernel.org/lkml/20181105165558.11698-1-daniel.m.jordan@oracle.com/

    The performance should improve by much more than 26%.

    Overall, your works looks good, but it needs to be considered how easy it will be
    to merge with ktask. I will try to complete the review today.

    Thank you,
    Pasha

    \
     
     \ /
      Last update: 2018-11-09 22:16    [W:4.113 / U:0.404 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site