lkml.org 
[lkml]   [2018]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: Re: [PATCH V3] binder: ipc namespace support for android binder(Internet mail)
    Date
    > >
    > > If IPC_NS is disabled, "current-nsporxy->ipc_ns" will also exists,  it will be a static
    > > reference of "init_ipc_ns" (in ipc/msgutil.c, not defined in binder.c by me) with
    > > no namespace-ization. You will get the same one in all processes, everything is
    > > the same as  without this patch.

    > except, as far as I can tell, binder_init_ns() would never have been
    > called on it so the mutex and list heads are not initialized so its
    > completely broken. Am I missing something? How do those fields get
    > initialized in this case?

    > @@ -5832,8 +5888,12 @@ static int __init binder_init(void)
    >                         goto err_init_binder_device_failed;
    >         }
    >
    > -       return ret;
    > +       ret = binder_init_ns(&init_ipc_ns);
    > +       if (ret)
    > +               goto err_init_namespace_failed;
    >
    > +       return ret;

    They are initialized here.

    - choury -

    \
     
     \ /
      Last update: 2018-11-10 06:44    [W:5.200 / U:0.428 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site