Messages in this thread | | | From | Tim Chen <> | Subject | Re: [Patch v4 08/18] sched: Deprecate sched_smt_present and use cpu_smt_enabled static key | Date | Fri, 9 Nov 2018 14:08:43 -0800 |
| |
Thomas,
> >> The cpu_smt_enabled static key serves identical purpose as cpu_smt_enabled > > That doesn't make any sense. > >> to enable SMT specific code. >> >> This patch replaces sched_smt_present in the scheduler with >> cpu_smt_enabled and deprecate sched_smt_present. > > It's not deprecating it, it's replacing and removing it and thereby > breaking all architectures which select SCHED_SMT except x86.
But the cpu_smt_enabled key is not x86 specific. It is set and defined in generic kernel/cpu.c and include/linux/cpu.h and available for all architectures.
Why would it break other architectures? I am missing something?
Thanks.
Tim
| |