lkml.org 
[lkml]   [2018]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    Subject[PATCH 0/2] phy: ocelot-serdes: fix out-of-bounds bug
    This patchset aims to fix an out-of-bounds bug in
    the phy-ocelot-serdes driver.

    Currently, there is an out-of-bounds read on array ctrl->phys,
    once variable i reaches the maximum array size of SERDES_MAX
    in the for loop.

    Quentin Schulz pointed out that SERDES_MAX is a valid value to
    index ctrl->phys. So, I updated SERDES_MAX to be SERDES6G_MAX + 1
    in include/dt-bindings/phy/phy-ocelot-serdes.h.

    Then I changed the condition in the for loop from
    i <= SERDES_MAX to i < SERDES_MAX in order to
    complete the fix.

    The reason I'm sending this fix as series is because
    checkpatch reported an error when I first tried to
    integrate the whole solution into a singe patch. So,
    changes to dt-bindings should be sent as a separate
    patch.

    Thanks

    Gustavo A. R. Silva (2):
    dt-bindings: phy: Update SERDES_MAX to be SERDES_MAX + 1
    phy: ocelot-serdes: fix out-of-bounds read

    drivers/phy/mscc/phy-ocelot-serdes.c | 4 ++--
    include/dt-bindings/phy/phy-ocelot-serdes.h | 2 +-
    2 files changed, 3 insertions(+), 3 deletions(-)

    --
    2.7.4

    \
     
     \ /
      Last update: 2018-10-09 00:20    [W:4.794 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site