Messages in this thread | | | Date | Mon, 8 Oct 2018 17:34:58 +0200 | From | Johan Hovold <> | Subject | Re: [PATCH stable v2 0/2] termios: Alpha BOTHER/IBSHIFT, tty_baudrate fix |
| |
On Sun, Oct 07, 2018 at 09:06:18PM -0700, H. Peter Anvin wrote: > From: "H. Peter Anvin (Intel)" <hpa@zytor.com> > > It turns out that Alpha is the only architecture that never > implemented BOTHER and IBSHIFT, which is otherwise ages old. This is > one thing that has held up glibc support for this feature (all other > architectures have supported these for about a decade, at least before > the current 3.2 glibc cutoff.) > > Furthermore, in the process of dealing with this, I discovered that > the current code in tty_baudrate.c can read past the end of the > baud_table[] on Alpha and PowerPC. The second patch in this series > fixes that, but it also cleans up the code substantially by > auto-generating the table and, since all architectures now have them, > removing all conditionals for BOTHER and IBSHIFT existing. > > Tagging for stable because these are concrete and immediate > problems.
This isn't stable material in its current form. If you want to plug the alpha and powerpc info leaks in the stable trees, then you need a minimal fix for that, which you can then your clean ups and new features on.
Johan
| |