lkml.org 
[lkml]   [2018]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] staging: erofs: add SPDX identifer
From
Date


On 2018/10/8 22:36, Gao Xiang wrote:
> Hi Greg,
>
> On 2018/10/8 22:22, Greg Kroah-Hartman wrote:
>> Why delete that line?
>>
>> But wait, why do we even have this file at all? What's wrong with the
>> lib/lz4/ code that we have in the kernel today? Shouldn't the code
>> using these files be moved over to use the lib/ code instead and this
>> file be deleted?
>
> EROFS uses customized LZ4 decompression code for now (which has been offically
> supported in lz4 1.8.3, I have updated it in
> https://ozlabs.org/~akpm/mmots/broken-out/lib-lz4-update-lz4-decompressor-module.patch
> if it is shown up in Linux 4.20, I will remove all the customized LZ4 decompression code),
> but lib/ code lz4def.h isn't export to include/.

Please refer to https://github.com/lz4/lz4/issues/566 for more details the reason why
EROFS uses the different implementation rather than the current lib/lz4/ code in the kernel today
(it will be changed in the next Linux version if the updated code works fine.)

Thanks,
Gao Xiang

>
> Thanks,
> Gao Xiang
>
>>
>> thanks,
>>
>> greg k-h

\
 
 \ /
  Last update: 2018-10-08 16:42    [W:2.046 / U:0.880 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site