Messages in this thread | | | Subject | Re: [PATCH v8 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver | From | Taniya Das <> | Date | Mon, 8 Oct 2018 16:29:10 +0530 |
| |
On 10/8/2018 4:08 PM, Niklas Cassel wrote: > On Mon, Oct 08, 2018 at 03:29:52PM +0530, Viresh Kumar wrote: >> On 08-10-18, 10:40, Niklas Cassel wrote: >>>> + ret = of_parse_phandle_with_args(cpu_np, "qcom,freq-domain", >>>> + "#freq-domain-cells", 0, &args); >>> >>> Hello Taniya, >>> >>> in your DT binding, you use >>> >>> #freq-domains-cells = <1> >>> >>> Yet here you parse for "#freq-domain-cells". >> >> And what is the problem with that ? Or are you suggesting her to call >> of_parse_phandle_with_fixed_args() ? > > Hello Viresh, > > #freq-domain-cells != #freq-domains-cells > > The code should parse for the exact same property name as stated in the > DT binding. > > Kind regards, > Niklas >
The extra 's' was a typo, would fix it in the next patch.
-- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation.
--
| |