lkml.org 
[lkml]   [2018]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 81/94] ovl: fix format of setxattr debug
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Miklos Szeredi <mszeredi@redhat.com>

    commit 1a8f8d2a443ef9ad9a3065ba8c8119df714240fa upstream.

    Format has a typo: it was meant to be "%.*s", not "%*s". But at some point
    callers grew nonprintable values as well, so use "%*pE" instead with a
    maximized length.

    Reported-by: Amir Goldstein <amir73il@gmail.com>
    Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
    Fixes: 3a1e819b4e80 ("ovl: store file handle of lower inode on copy up")
    Cc: <stable@vger.kernel.org> # v4.12
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/overlayfs/overlayfs.h | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/fs/overlayfs/overlayfs.h
    +++ b/fs/overlayfs/overlayfs.h
    @@ -136,8 +136,8 @@ static inline int ovl_do_setxattr(struct
    const void *value, size_t size, int flags)
    {
    int err = vfs_setxattr(dentry, name, value, size, flags);
    - pr_debug("setxattr(%pd2, \"%s\", \"%*s\", 0x%x) = %i\n",
    - dentry, name, (int) size, (char *) value, flags, err);
    + pr_debug("setxattr(%pd2, \"%s\", \"%*pE\", %zu, 0x%x) = %i\n",
    + dentry, name, min((int)size, 48), value, size, flags, err);
    return err;
    }


    \
     
     \ /
      Last update: 2018-10-08 21:05    [W:6.055 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site