lkml.org 
[lkml]   [2018]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.18 118/168] net: ena: fix surprise unplug NULL dereference kernel crash
    Date
    4.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Netanel Belgazal <netanel@amazon.com>

    [ Upstream commit 772ed869f535b4ec2b134645c951ff22de4d3f79 ]

    Starting with driver version 1.5.0, in case of a surprise device
    unplug, there is a race caused by invoking ena_destroy_device()
    from two different places. As a result, the readless register might
    be accessed after it was destroyed.

    Signed-off-by: Netanel Belgazal <netanel@amazon.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/amazon/ena/ena_netdev.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
    +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
    @@ -3408,12 +3408,12 @@ static void ena_remove(struct pci_dev *p
    netdev->rx_cpu_rmap = NULL;
    }
    #endif /* CONFIG_RFS_ACCEL */
    -
    - unregister_netdev(netdev);
    del_timer_sync(&adapter->timer_service);

    cancel_work_sync(&adapter->reset_task);

    + unregister_netdev(netdev);
    +
    /* Reset the device only if the device is running. */
    if (test_bit(ENA_FLAG_DEVICE_RUNNING, &adapter->flags))
    ena_com_dev_reset(ena_dev, adapter->reset_reason);

    \
     
     \ /
      Last update: 2018-10-08 20:57    [W:4.161 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site