lkml.org 
[lkml]   [2018]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.18 148/168] ovl: fix memory leak on unlink of indexed file
    Date
    4.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Amir Goldstein <amir73il@gmail.com>

    commit 63e132528032ce937126aba591a7b37ec593a6bb upstream.

    The memory leak was detected by kmemleak when running xfstests
    overlay/051,053

    Fixes: caf70cb2ba5d ("ovl: cleanup orphan index entries")
    Cc: <stable@vger.kernel.org> # v4.13
    Signed-off-by: Amir Goldstein <amir73il@gmail.com>
    Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/overlayfs/util.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/fs/overlayfs/util.c
    +++ b/fs/overlayfs/util.c
    @@ -531,7 +531,7 @@ static void ovl_cleanup_index(struct den
    struct dentry *upperdentry = ovl_dentry_upper(dentry);
    struct dentry *index = NULL;
    struct inode *inode;
    - struct qstr name;
    + struct qstr name = { };
    int err;

    err = ovl_get_index_name(lowerdentry, &name);
    @@ -574,6 +574,7 @@ static void ovl_cleanup_index(struct den
    goto fail;

    out:
    + kfree(name.name);
    dput(index);
    return;


    \
     
     \ /
      Last update: 2018-10-08 20:57    [W:2.234 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site