lkml.org 
[lkml]   [2018]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 065/113] net: hns: fix length and page_offset overflow when CONFIG_ARM64_64K_PAGES
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Huazhong Tan <tanhuazhong@huawei.com>

    [ Upstream commit 3ed614dce3ca9912d22be215ff0f11104b69fe62 ]

    When enable the config item "CONFIG_ARM64_64K_PAGES", the size of PAGE_SIZE
    is 65536(64K). But the type of length and page_offset are u16, they will
    overflow. So change them to u32.

    Fixes: 6fe6611ff275 ("net: add Hisilicon Network Subsystem hnae framework support")
    Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
    Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/hisilicon/hns/hnae.h | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    --- a/drivers/net/ethernet/hisilicon/hns/hnae.h
    +++ b/drivers/net/ethernet/hisilicon/hns/hnae.h
    @@ -171,10 +171,10 @@ struct hnae_desc_cb {

    /* priv data for the desc, e.g. skb when use with ip stack*/
    void *priv;
    - u16 page_offset;
    - u16 reuse_flag;
    + u32 page_offset;
    + u32 length; /* length of the buffer */

    - u16 length; /* length of the buffer */
    + u16 reuse_flag;

    /* desc type, used by the ring user to mark the type of the priv data */
    u16 type;

    \
     
     \ /
      Last update: 2018-10-08 20:36    [W:5.104 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site