lkml.org 
[lkml]   [2018]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/7] staging: vc04_services: Some dead code removal
    Hi Tuomas,

    > Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi> hat am 4. Oktober 2018 um 11:37 geschrieben:
    >
    >
    > Drop various pieces of dead code from here and there to get rid of
    > the remaining users of VCHI_CONNECTION_T. After that we get to drop
    > entire header files worth of unused code.
    >
    > I've tested on a Raspberry Pi Model B (bcm2835_defconfig) that
    > snd-bcm2835 can still play analog audio just fine.
    >

    thanks and i'm fine with your patch series:

    Acked-by: Stefan Wahren <stefan.wahren@i2se.com>

    Unfortunately this would break compilation of the downstream vchi drivers like vcsm [1]. Personally i don't want to maintain another one, because i cannot see the gain of the resulting effort.

    [1] - https://github.com/raspberrypi/linux/tree/rpi-4.14.y/drivers/char/broadcom/vc_sm

    \
     
     \ /
      Last update: 2018-10-06 12:21    [W:8.528 / U:0.304 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site