[lkml]   [2018]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] staging/rtlwifi: Fixing formatting warnings from
On Fri, Oct 5, 2018 at 6:37 PM Joe Perches <> wrote:
> On Fri, 2018-10-05 at 16:58 -0600, Scott Tracy wrote:
> > Fixing formatting warnings in rtlwifi found by
> > Changes include breaking up functions calls into multi line calls.
> > No functional/logical changes.
> I believe the code is better before most of these changes.
> There are various tradeoffs do source code formatting.
> Here you are changing some alignment to open parentheses
> and converting to < 80 columns.

Thanks for the criticism. Fair comments all. I was just working
through the tutorial looking for low value changes
to get my feet wet and assumed that a "check" was better than a
"warning". A also didn't feel confident enough to refactor the code to
get under the 80 character limit. Maybe I will spend a little more
time refactoring something and then submitting that. Thanks again,

Scott Tracy

 \ /
  Last update: 2018-10-06 03:23    [W:0.039 / U:6.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site