Messages in this thread | | | From | Max Filippov <> | Date | Thu, 4 Oct 2018 15:35:33 -0700 | Subject | Re: [PATCH 5/5] arch/xtensa, termios: use <asm-generic/termbits.h> |
| |
On Thu, Oct 4, 2018 at 3:30 PM H. Peter Anvin (Intel) <hpa@zytor.com> wrote: > > The Xtensa definition of termbits.h is identical to the generic one. > > Signed-off-by: H. Peter Anvin (Intel) <hpa@zytor.com> > Cc: Chris Zankel <chris@zankel.net> > Cc: Max Filippov <jcmvbkbc@gmail.com> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Philippe Ombredanne <pombredanne@nexb.com> > Cc: Kate Stewart <kstewart@linuxfoundation.org> > Cc: <linux-xtensa@linux-xtensa.org> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Jiri Slaby <jslaby@suse.com> > --- > arch/xtensa/include/uapi/asm/termbits.h | 222 +------------------------------- > 1 file changed, 1 insertion(+), 221 deletions(-)
Looks good. But why not removing the header entirely and adding generic-y += termbits.h to arch/xtensa/include/uapi/asm/Kbuild?
-- Thanks. -- Max
| |