Messages in this thread | | | Subject | Re: [PATCH v2 1/5] ALSA: soc-compress: add support to snd_compr_set_runtime_buffer() | From | Srinivas Kandagatla <> | Date | Fri, 5 Oct 2018 09:16:26 +0100 |
| |
Thanks for review!
On 05/10/18 01:31, Vinod wrote: > On 26-09-18, 11:23, Srinivas Kandagatla wrote: >> This patch adds support to set runtime dma buffer on compressed stream. > The change is fine as is, but I feel we need to document the motivation > in the changelog. The core changes need a bit more explanation on why we > should add this..
Sure, I will add more information into the change log in next version.
--srini
> >> Signed-off-by: Srinivas Kandagatla<srinivas.kandagatla@linaro.org> >> --- >> include/sound/compress_driver.h | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> >> diff --git a/include/sound/compress_driver.h b/include/sound/compress_driver.h >> index ea8c93bbb0e0..0cdc3999ecfa 100644 >> --- a/include/sound/compress_driver.h >> +++ b/include/sound/compress_driver.h >> @@ -23,6 +23,7 @@ struct snd_compr_ops; >> * struct snd_compr_runtime: runtime stream description >> * @state: stream state >> * @ops: pointer to DSP callbacks
| |