Messages in this thread | | | From | Arnd Bergmann <> | Date | Fri, 5 Oct 2018 09:43:20 +0200 | Subject | Re: [PATCH -next] eeprom: at25: remove unneeded 'at25_remove' |
| |
On Fri, Oct 5, 2018 at 8:08 AM YueHaibing <yuehaibing@huawei.com> wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/misc/eeprom/at25.c: In function 'at25_remove': > drivers/misc/eeprom/at25.c:384:20: warning: > variable 'at25' set but not used [-Wunused-but-set-variable] > > Since commit 96d08fb43e30 ("eeprom: at25: use devm_nvmem_register()"), > at25_remove is do nothing, so can be removed. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
I had to double-check that removing the remove callback doesn't result in a device that you cannot remove, but it is in fact supported, so
Acked-by: Arnd Bergmann <arnd@arndb.de>
| |