Messages in this thread | | | Date | Fri, 5 Oct 2018 10:29:55 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH] crypto/morus(640,1280) - make crypto_...-algs static |
| |
On Wed, Sep 26, 2018 at 06:49:38PM -0400, valdis.kletnieks@vt.edu wrote: > sparse complains thusly: > > CHECK arch/x86/crypto/morus640-sse2-glue.c > arch/x86/crypto/morus640-sse2-glue.c:38:1: warning: symbol 'crypto_morus640_sse2_algs' was not declared. Should it be static? > CHECK arch/x86/crypto/morus1280-sse2-glue.c > arch/x86/crypto/morus1280-sse2-glue.c:38:1: warning: symbol 'crypto_morus1280_sse2_algs' was not declared. Should it be static? > CHECK arch/x86/crypto/morus1280-avx2-glue.c > arch/x86/crypto/morus1280-avx2-glue.c:38:1: warning: symbol 'crypto_morus1280_avx2_algs' was not declared. Should it be static? > > and sparse is correct - these don't need to be global and polluting the namespace. > > Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Patch applied. Thanks. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |