Messages in this thread | | | Subject | Re: [PATCH] reset: socfpga: add an early reset driver for SoCFPGA | From | Dinh Nguyen <> | Date | Fri, 5 Oct 2018 15:23:28 -0500 |
| |
Hi Philipp,
I apologize, but I just realized that I forgot to test this patch against the SoCFPGA ARM64 platform. I just tested against that platform and this patch is preventing that board from booting.
I need to redo this patch.
If its not too late, can you remove this patch from reset/next?
Thanks, Dinh
On 10/05/2018 10:30 AM, Philipp Zabel wrote: > Hi Dinh, > > On Fri, 2018-10-05 at 10:17 -0500, Dinh Nguyen wrote: > [...] >>>> +static int a10_reset_init(struct device_node *np) >>>> +{ >>>> + struct reset_simple_data *data; >>>> + struct resource res; >>>> + resource_size_t size; >>>> + int ret; >>>> + u32 reg_offset = 0; >>> >>> ... now it is 0x0. >>> I think this should be >>> >>> u32 reg_offset = 0x10; >>> >>> to avoid breaking SocFPGA with ancient device trees. > [...] >>> Could we keep the SOCFPGA_NR_BANKS #define to reduce the amount of magic >>> numbers? >>> >>> I can make both changes when applying if you want. >>> >> >> If you don't mind, that would be great! > > Done, applied to reset/next with the above changes. > > > I get the following build warning: > > drivers/reset/reset-socfpga.c:81:13: warning: symbol 'socfpga_reset_init' was not declared. Should it be static? > > It would be nice to put the declaration into a header in > include/soc/socfpga (or wherever is more appropriate) at some point. > > regards > Philipp >
| |