Messages in this thread | | | Subject | Re: [PATCH 2/2] cpuidle/drivers/menu: Remove get_loadavg in the performance multiplier | From | Joe Perches <> | Date | Thu, 04 Oct 2018 10:16:46 -0700 |
| |
On Thu, 2018-10-04 at 10:40 +0200, Daniel Lezcano wrote: > On 04/10/2018 10:22, Rafael J. Wysocki wrote: > > On Thu, Oct 4, 2018 at 9:42 AM Daniel Lezcano <daniel.lezcano@linaro.org> wrote: > > > The function get_loadavg() returns almost always zero. To be more > > > precise, statistically speaking for a total of 1023379 times passing > > > in the function, the load is equal to zero 1020728 times, greater than > > > 100, 610 times, the remaining is between 0 and 5. [] > > > diff --git a/drivers/cpuidle/governors/menu.c b/drivers/cpuidle/governors/menu.c [] > > > @@ -359,7 +346,8 @@ static int menu_select(struct cpuidle_driver *drv, struct cpuidle_device *dev, > > > * Use the performance multiplier and the user-configurable > > > * latency_req to determine the maximum exit latency. > > > */ > > > - interactivity_req = data->predicted_us / performance_multiplier(nr_iowaiters, cpu_load); > > > + interactivity_req = data->predicted_us / > > > + performance_multiplier(nr_iowaiters); > > > > I wouldn't break this line. > > Ok, mind if I break the line in a separate patch before ? (my git > pre-commit hook runs checkpatch and it complains and prevent to commit > the patch because of the line length (94)).
A lot of this file uses > 80 column lines. As well, the identifiers here are relatively long.
Long identifier lengths and 80 column lines are generally incompatible.
I suggest you change your script to allow > 80 column lines using the checkpatch command-line option --ignore==long_line or perhaps add --max-line-length=<some higher value> or at least allow some other senstible interactivity when the silly script bleats some mindless warning or another.
| |