lkml.org 
[lkml]   [2018]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH v2] rtc: m41t80: mark expected switch fall-through
    In preparation to enabling -Wimplicit-fallthrough, mark switch cases
    where we are expecting to fall through.

    Notice that in this particular case, I replaced "Fall" with a proper
    "Fall through" comment.

    Addresses-Coverity-ID: 1373875 ("Missing break in switch")
    Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
    ---
    Changes in v2:
    - Change subject and commit log.

    drivers/rtc/rtc-m41t80.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c
    index ad03e2f..a3fb235 100644
    --- a/drivers/rtc/rtc-m41t80.c
    +++ b/drivers/rtc/rtc-m41t80.c
    @@ -745,7 +745,7 @@ static int wdt_ioctl(struct file *file, unsigned int cmd,
    return -EINVAL;
    wdt_margin = new_margin;
    wdt_ping();
    - /* Fall */
    + /* Fall through */
    case WDIOC_GETTIMEOUT:
    return put_user(wdt_margin, (int __user *)arg);

    --
    2.7.4
    \
     
     \ /
      Last update: 2018-10-04 15:08    [W:4.281 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site