Messages in this thread | | | Date | Thu, 4 Oct 2018 14:18:07 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH v7 12/14] sched/fair: Select an energy-efficient CPU on task wake-up |
| |
On Thu, Oct 04, 2018 at 11:55:09AM +0100, Quentin Perret wrote: > On Thursday 04 Oct 2018 at 12:41:07 (+0200), Peter Zijlstra wrote: > > Not sure, see what it looks like ;-) My main concern here was to get rid > > of that giant blob in select_task_rq_fair(). > > OK, got it. I'll probably just move the checks into the function and > merge that large comment into the already massive comment above > find_energy_efficient_cpu() or something. We'll see :-) > > And do you actually care about the function name ? We've been using > find_energy_efficient_cpu() for some time in Android now, so that's just > slightly easier for us if that can be re-used. Not a big deal either, > though.
Sure, that's fine I suppose.
| |