Messages in this thread | | | Subject | Re: [RESEND PATCHv2] misc: cxl: Fix possible null pointer dereference | From | Frederic Barrat <> | Date | Thu, 4 Oct 2018 13:48:07 +0200 |
| |
Le 04/10/2018 à 07:02, zhong jiang a écrit : > It is not safe to dereference an object before a null test. It is > not needed and just remove them. Ftrace can be used instead. > > Signed-off-by: zhong jiang <zhongjiang@huawei.com> > ---
Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>
> drivers/misc/cxl/guest.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/misc/cxl/guest.c b/drivers/misc/cxl/guest.c > index 3bc0c15..5d28d9e 100644 > --- a/drivers/misc/cxl/guest.c > +++ b/drivers/misc/cxl/guest.c > @@ -1018,8 +1018,6 @@ int cxl_guest_init_afu(struct cxl *adapter, int slice, struct device_node *afu_n > > void cxl_guest_remove_afu(struct cxl_afu *afu) > { > - pr_devel("in %s - AFU(%d)\n", __func__, afu->slice); > - > if (!afu) > return; >
| |