Messages in this thread | | | Subject | Re: [PATCH net] net: mvpp2: Extract the correct ethtype from the skb for tx csum offload | From | Sergei Shtylyov <> | Date | Thu, 4 Oct 2018 12:50:17 +0300 |
| |
Hello!
On 10/4/2018 11:03 AM, Maxime Chevallier wrote:
> When offloading the L3 and L4 csum computation on TX, we need to extract > the l3_proto from the ethtype, independently of the presence of a vlan > tag. > > The actual driver uses skb->protocol as-is, resulting in packets with > the wrong L4 checksum being sent when there's a vlan tag in the packet > header and checksum offloading is enabled. > > This commit makes use of vlan_protocol_get() to get the correct ethtype > regardless the presence of a vlan tag. ^ of?
> Fixes: 3f51850 ("ethernet: Add new driver for Marvell Armada 375 network unit")
12 hex digits needed here.
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
[...]
MBR, Sergei
| |