Messages in this thread | | | From | Colin Ian King <> | Subject | Re: [SCSI] pmcraid: PMC-Sierra MaxRAID driver to support 6Gb/s SAS RAID controller | Date | Thu, 4 Oct 2018 09:28:19 +0100 |
| |
Hi,
Static analysis from CoverityScan (CID#114178 "Operands don't affect result") detected an issue in drivers/scsi/pmcraid.c, function pmcraid_init_res_table with the following check:
if (pinstance->cfg_table->flags & MICROCODE_UPDATE_REQUIRED) pmcraid_err("IOA requires microcode download\n");
pinstance->cfg_table->flags is a u8, MICROCODE_UPDATE_REQUIRED is 1 << 31, so the & operation always results in false and the error message is never displayed. From my understanding, flags should be a u8, so there is something wrong here with the check. Any ideas?
Colin
| |