lkml.org 
[lkml]   [2018]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH v3 1/7] book3s/64: avoid circular header inclusion in mmu-hash.h
From
Date
On 10/4/18 1:50 PM, Christophe LEROY wrote:
>
>
> Le 03/10/2018 à 06:24, Nicholas Piggin a écrit :
>> On Mon,  1 Oct 2018 12:30:19 +0000 (UTC)
>> Christophe Leroy <christophe.leroy@c-s.fr> wrote:
>>
>>> When activating CONFIG_THREAD_INFO_IN_TASK, linux/sched.h
>>> includes asm/current.h. This generates a circular dependency.
>>> To avoid that, asm/processor.h shall not be included in mmu-hash.h
>>>
>>> In order to do that, this patch moves into a new header called
>>> asm/task_size.h the information from asm/processor.h requires by
>>> mmu-hash.h
>>
>> Doesn't look like you use this header in 32-bit code. Put task_size.h
>> in asm/64/ maybe?
>
> There is no asm/64/ dir at the time being, only book3s/64/ and nohash/64/
>
> I'm thinking about leaving it in asm/ but renaming it task_size_user64.h
>

Quiet a lot of that is book3s 64 specifi because we have there.

#if defined(CONFIG_PPC_BOOK3S_64) && defined(CONFIG_PPC_64K_PAGES)
/*
* Max value currently used:
*/


-aneesh

\
 
 \ /
  Last update: 2018-10-04 10:24    [W:0.519 / U:0.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site