Messages in this thread | | | Date | Wed, 3 Oct 2018 21:38:12 -0700 | From | Greg KH <> | Subject | Re: [PATCHv2] misc: cxl: delete possible null pointer dereference |
| |
On Thu, Oct 04, 2018 at 10:56:48AM +0800, zhong jiang wrote: > It is safe to dereference an object below a NULL test. For the sake > of debugging. Just delete the call of possible null pointer dereference. > > Signed-off-by: zhong jiang <zhongjiang@huawei.com> > --- > drivers/misc/cxl/guest.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/cxl/guest.c b/drivers/misc/cxl/guest.c > index 3bc0c15..472e8db 100644 > --- a/drivers/misc/cxl/guest.c > +++ b/drivers/misc/cxl/guest.c > @@ -1018,7 +1018,7 @@ int cxl_guest_init_afu(struct cxl *adapter, int slice, struct device_node *afu_n > > void cxl_guest_remove_afu(struct cxl_afu *afu) > { > - pr_devel("in %s - AFU(%d)\n", __func__, afu->slice); > + pr_devel("in %s\n", __func__);
This call should just be deleted, it's not needed, ftrace can be used instead.
thanks,
greg k-h
| |