Messages in this thread | | | Date | Thu, 4 Oct 2018 10:45:08 +0800 | From | zhong jiang <> | Subject | Re: [PATCH] misc: cxl: Move a deference below a NULL test |
| |
On 2018/10/3 6:55, Greg KH wrote: > On Wed, Sep 26, 2018 at 07:41:12PM +0800, zhong jiang wrote: >> It is safe to move a deference below a NULL test. >> >> Signed-off-by: zhong jiang <zhongjiang@huawei.com> >> Acked-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com> >> --- >> drivers/misc/cxl/guest.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/misc/cxl/guest.c b/drivers/misc/cxl/guest.c >> index 3bc0c15..559e835 100644 >> --- a/drivers/misc/cxl/guest.c >> +++ b/drivers/misc/cxl/guest.c >> @@ -1018,11 +1018,11 @@ int cxl_guest_init_afu(struct cxl *adapter, int slice, struct device_node *afu_n >> >> void cxl_guest_remove_afu(struct cxl_afu *afu) >> { >> - pr_devel("in %s - AFU(%d)\n", __func__, afu->slice); >> - >> if (!afu) >> return; >> >> + pr_devel("in %s - AFU(%d)\n", __func__, afu->slice); >> + > This call should just be deleted, ftrace can be used if this type of > thing is really needed. Ok, just delete the dereference in advance. Will repost in v2.
Thanks, zhong jiang > thanks, > > greg k-h > > . >
| |