Messages in this thread | | | From | Linus Walleij <> | Date | Wed, 31 Oct 2018 14:33:24 +0100 | Subject | Re: [PATCH] pinctrl: generic: Avoid several implicit enum conversions |
| |
On Thu, Oct 25, 2018 at 11:04 PM Nathan Chancellor <natechancellor@gmail.com> wrote:
> In my opinion, there are enough of these warnings to warrant changing > the type of param globally (arm64 allyesconfig):
Yeah as it is from the compiler, sure we need to get rid of it.
> Linus, did you have any other objections to this patch given my > reasoning in these past couple of emails or would you like me to try > adding explicit casts to all of these call sites?
I would favor the model to:
1. Replace all occurences of enum pin_config_param with unsigned int.
2. Replace the whole definition of enum pin_config_param with #define PIN_CONFIG_BIAS_BUS_HOLD 0 #define PIN_CONFIG_BIAS_DISABLE 1 etc etc.
I think it is not a good idea to try to do both at the same time.
A slightly lesser evil variant is to add a few PIN_CONFIG_CUSTOM_1 PIN_CONFIG_CUSTOM_2 etc at the end of the enum and just #define MY_CONFIG PIN_CONFIG_CUSTOM_1 in all drivers that use these.
Yours, Linus Walleij
| |