Messages in this thread | | | From | Sam Protsenko <> | Date | Tue, 30 Oct 2018 21:31:19 +0200 | Subject | Re: [PATCH v2] kernel/SRCU: Fix ctags |
| |
On Mon, Oct 29, 2018 at 10:11 PM, Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Mon, Oct 29, 2018 at 10:09 PM Sam Protsenko > <semen.protsenko@linaro.org> wrote: >> >> ctags indexing ("make tags" command) throws this warning: >> >> ctags: Warning: include/linux/notifier.h:125: >> null expansion of name pattern "\1" >> >> This is the result of DEFINE_PER_CPU() macro exapansion. Fix that by >> getting rid of line break. >> >> Similar fix was already done in commit 25528213fe9f ("tags: Fix >> DEFINE_PER_CPU expansions"), but this one probably wasn't noticed. > > Why not to add Fixes tag here as well? >
Will do, thanks, Andy!
>> >> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> >> --- >> include/linux/notifier.h | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/include/linux/notifier.h b/include/linux/notifier.h >> index f35c7bf76143..0096a05395e3 100644 >> --- a/include/linux/notifier.h >> +++ b/include/linux/notifier.h >> @@ -122,8 +122,7 @@ extern void srcu_init_notifier_head(struct srcu_notifier_head *nh); >> >> #ifdef CONFIG_TREE_SRCU >> #define _SRCU_NOTIFIER_HEAD(name, mod) \ >> - static DEFINE_PER_CPU(struct srcu_data, \ >> - name##_head_srcu_data); \ >> + static DEFINE_PER_CPU(struct srcu_data, name##_head_srcu_data); \ >> mod struct srcu_notifier_head name = \ >> SRCU_NOTIFIER_INIT(name, name##_head_srcu_data) >> >> -- >> 2.19.1 >> > > > -- > With Best Regards, > Andy Shevchenko
| |