Messages in this thread | | | From | Doug Anderson <> | Date | Tue, 30 Oct 2018 09:52:00 -0700 | Subject | Re: [PATCH] arm64: dts: sdm845: Add PSCI cpuidle low power states |
| |
Resending since I accidentally clicked back to HTML and lists all bounced. :(
On Tue, Oct 30, 2018 at 9:24 AM Raju P L S S S N <rplsssn@codeaurora.org> wrote: > > On 10/24/2018 12:06 AM, Doug Anderson wrote: > > Hi, > > > > On Mon, Oct 15, 2018 at 10:02 AM Raju P.L.S.S.S.N > > <rplsssn@codeaurora.org> wrote: > >> + idle-states { > >> + entry-method = "psci"; > >> + > >> + C0_CPU_SPC: c0_spc { > > > > nit: all these nodes should have dashes instead of spaces in the node > > names (labels can still have spaces). AKA: > > > > C0_CPU_SPC: c0-spc { > > Sure. I will change this. (However, from device tree specification v0.2, > I see that Table 2.1 mentions underscore as valid character for node. > Please correct me if I'm missing something)
You're right that I don't see it there. I've always heard that they are allowed but discouraged. One place that mentions this:
https://elinux.org/Device_Tree_Linux
> Linux conventions > * node names > * use dash "-" instead of underscore "_"
That same site points that the majority of people use dashes in node names instead of underscores.
-Doug
| |