Messages in this thread | | | Date | Mon, 29 Oct 2018 20:55:13 +0100 | From | Eugene Syromiatnikov <> | Subject | Re: [PATCH RESEND 1/2] fcntl: fix typo in RWH_WRITE_LIFE_NOT_SET r/w hint |
| |
On Fri, Oct 26, 2018 at 08:44:35AM -0600, Jens Axboe wrote: > On 10/25/18 3:54 PM, Eugene Syromiatnikov wrote: > > According to commit message in the original commit v4.13-rc1~212^2~51, > > as well as userspace library[1] and man page update[2], R/W hint constants > > are intended to have RWH_* prefix. However, RWF_WRITE_LIFE_NOT_SET retained > > "RWF_*" prefix used in earlyy versions of the proposed patch set[3]. > > Rename it and provide the old name as a synonym for the new one > > for backward compatibility. > > > > [1] https://github.com/axboe/fio/commit/bd553af6c849 > > [2] https://github.com/mkerrisk/man-pages/commit/580082a186fd > > [3] https://www.mail-archive.com/linux-block@vger.kernel.org/msg09638.html > > Looks good, thanks for catching this. One note: > > > Fixes: c75b1d9421f8 ("fs: add fcntl() interface for setting/getting write life time hints") > > Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com> > > Signed-off-by: Eugene Syromyatnikov <evgsyr@gmail.com> > > Why do you have two separate sign-offs?
Uh, sorry, I've messed up format-patch flags again.
> -- > Jens Axboe >
| |