Messages in this thread | | | From | Viresh Kumar <> | Date | Tue, 30 Oct 2018 11:20:19 +0530 | Subject | Re: [PATCH 1/4] base/drivers/arch_topology: Remove useless check |
| |
On Mon, Oct 29, 2018 at 9:56 PM Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
Would have been better if I was cc'd on all the patches since I was looking at this stuff actively this week :)
> The function 'register_cpufreq_notifier' registers the > init_cpu_capacity_notifier() only if raw_capacity is not NULL. > > Hence init_cpu_capacity_notifier() can not be called with raw_capacity > set to NULL, it is pointless to check it.
It isn't entirely pointless though.
It is possible for init_cpu_capacity_notifier() to get called after free_raw_capacity() is called from it as the notifier unregistration happens from a workqueue.
| |