lkml.org 
[lkml]   [2018]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 14/16] netfilter: Replace spin_is_locked() with lockdep
    On Tue, 2 Oct 2018, Lance Roy wrote:

    > lockdep_assert_held() is better suited to checking locking requirements,
    > since it won't get confused when someone else holds the lock. This is
    > also a step towards possibly removing spin_is_locked().
    >
    > Signed-off-by: Lance Roy <ldr709@gmail.com>
    > Cc: Pablo Neira Ayuso <pablo@netfilter.org>
    > Cc: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
    > Cc: Florian Westphal <fw@strlen.de>
    > Cc: "David S. Miller" <davem@davemloft.net>
    > Cc: <netfilter-devel@vger.kernel.org>
    > Cc: <coreteam@netfilter.org>
    > Cc: <netdev@vger.kernel.org>
    > ---
    > net/netfilter/ipset/ip_set_hash_gen.h | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)

    Acked-by: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>

    Best regards,
    Jozsef

    > diff --git a/net/netfilter/ipset/ip_set_hash_gen.h b/net/netfilter/ipset/ip_set_hash_gen.h
    > index 8a33dac4e805..e287da68d5fa 100644
    > --- a/net/netfilter/ipset/ip_set_hash_gen.h
    > +++ b/net/netfilter/ipset/ip_set_hash_gen.h
    > @@ -15,7 +15,7 @@
    >
    > #define __ipset_dereference_protected(p, c) rcu_dereference_protected(p, c)
    > #define ipset_dereference_protected(p, set) \
    > - __ipset_dereference_protected(p, spin_is_locked(&(set)->lock))
    > + __ipset_dereference_protected(p, lockdep_is_held(&(set)->lock))
    >
    > #define rcu_dereference_bh_nfnl(p) rcu_dereference_bh_check(p, 1)
    >
    > --
    > 2.19.0
    >
    >

    -
    E-mail : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.mta.hu
    PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
    Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
    H-1525 Budapest 114, POB. 49, Hungary

    \
     
     \ /
      Last update: 2018-10-03 10:31    [W:3.259 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site