Messages in this thread | | | Date | Sun, 28 Oct 2018 03:23:46 -0700 | From | Matthew Wilcox <> | Subject | Re: [PATCH] mm: simplify get_next_ra_size |
| |
On Sun, Oct 28, 2018 at 02:13:26PM +0800, Gao Xiang wrote: > It's a trivial simplification for get_next_ra_size and > clear enough for humans to understand. > > It also fixes potential overflow if ra->size(< ra_pages) is too large. > > Cc: Fengguang Wu <fengguang.wu@intel.com> > Signed-off-by: Gao Xiang <hsiangkao@aol.com>
Reviewed-by: Matthew Wilcox <willy@infradead.org>
I also considered what would happen with underflow (passing a 'max' less than 16, or less than 2) and it would seem to do the right thing in that case.
| |