Messages in this thread | | | Subject | Re: [PATCH 4/5] staging: rtl8188eu: change return type of rtw_hal_xmit() | From | Joe Perches <> | Date | Sat, 27 Oct 2018 16:08:02 -0700 |
| |
On Sat, 2018-10-27 at 15:57 -0700, Joe Perches wrote: > On Sat, 2018-10-27 at 22:28 +0200, Michael Straube wrote: > > The function rtw_hal_xmit() returns true or false. > > Change the return type from s32 to bool. > [] > > diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c b/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c > [] > > @@ -598,7 +598,7 @@ bool rtl8188eu_xmitframe_complete(struct adapter *adapt, > > * true dump packet directly > > * false enqueue packet > > */ > > -s32 rtw_hal_xmit(struct adapter *adapt, struct xmit_frame *pxmitframe) > > +bool rtw_hal_xmit(struct adapter *adapt, struct xmit_frame *pxmitframe) > > { > > s32 res; > > Does "s32 res" need changing to bool too?
Perhaps all the functions regardless of types with returns of only _SUCCESS and _FAIL could be converted to bool.
| |