Messages in this thread | | | Date | Fri, 26 Oct 2018 18:30:04 +0200 | From | Boris Brezillon <> | Subject | Re: [PATCH v10 0/9] Add the I3C subsystem |
| |
On Fri, 26 Oct 2018 17:20:42 +0100 vitor <vitor.soares@synopsys.com> wrote:
> On 26/10/18 17:15, Boris Brezillon wrote: > > On Fri, 26 Oct 2018 16:22:06 +0100 > > vitor <vitor.soares@synopsys.com> wrote: > > > >> Can you update the i3c/next tree? > > Done. > > Thanks. > > I will apply the driver and them I give you feedback.
Great! Note that the bug in the ->send_ccc_cmd() path should be fixed, but you might have issues with i2c transfers as msg->buf is not guaranteed to be aligned on 32-bit.
Don't know if you've followed the discussion with Arnd, but it seems some (most?) archs are making sure writesl()/readsl() work for unaligned bufs. Maybe we should fix that for ARC. The other solution is to use i2c_get_dma_safe_msg_buf() to get something aligned on a cache-line and by extension aligned on 32bits.
| |