lkml.org 
[lkml]   [2018]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH RESEND 1/2] fcntl: fix typo in RWH_WRITE_LIFE_NOT_SET r/w hint
From
Date
On 10/25/18 3:54 PM, Eugene Syromiatnikov wrote:
> According to commit message in the original commit v4.13-rc1~212^2~51,
> as well as userspace library[1] and man page update[2], R/W hint constants
> are intended to have RWH_* prefix. However, RWF_WRITE_LIFE_NOT_SET retained
> "RWF_*" prefix used in earlyy versions of the proposed patch set[3].
> Rename it and provide the old name as a synonym for the new one
> for backward compatibility.
>
> [1] https://github.com/axboe/fio/commit/bd553af6c849
> [2] https://github.com/mkerrisk/man-pages/commit/580082a186fd
> [3] https://www.mail-archive.com/linux-block@vger.kernel.org/msg09638.html

Looks good, thanks for catching this. One note:

> Fixes: c75b1d9421f8 ("fs: add fcntl() interface for setting/getting write life time hints")
> Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
> Signed-off-by: Eugene Syromyatnikov <evgsyr@gmail.com>

Why do you have two separate sign-offs?

--
Jens Axboe

\
 
 \ /
  Last update: 2018-10-26 16:48    [W:0.093 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site