lkml.org 
[lkml]   [2018]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRE: [PATCH 3/6] PCI: layerscape: Add the EP mode support
    Date


    -----Original Message-----
    From: Rob Herring <robh@kernel.org>
    Sent: 2018年10月26日 5:53
    To: Xiaowei Bao <xiaowei.bao@nxp.com>
    Cc: bhelgaas@google.com; mark.rutland@arm.com; shawnguo@kernel.org; Leo Li <leoyang.li@nxp.com>; kishon@ti.com; lorenzo.pieralisi@arm.com; arnd@arndb.de; gregkh@linuxfoundation.org; M.h. Lian <minghuan.lian@nxp.com>; Mingkai Hu <mingkai.hu@nxp.com>; Roy Zang <roy.zang@nxp.com>; kstewart@linuxfoundation.org; cyrille.pitchen@free-electrons.com; pombredanne@nexb.com; shawn.lin@rock-chips.com; niklas.cassel@axis.com; linux-pci@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linuxppc-dev@lists.ozlabs.org
    Subject: Re: [PATCH 3/6] PCI: layerscape: Add the EP mode support

    On Thu, Oct 25, 2018 at 07:08:58PM +0800, Xiaowei Bao wrote:
    > Add the EP mode support.
    >
    > Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com>
    > ---
    > .../devicetree/bindings/pci/layerscape-pci.txt | 3 +++
    > 1 files changed, 3 insertions(+), 0 deletions(-)
    >
    > diff --git a/Documentation/devicetree/bindings/pci/layerscape-pci.txt b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
    > index 66df1e8..d3d7be1 100644
    > --- a/Documentation/devicetree/bindings/pci/layerscape-pci.txt
    > +++ b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
    > @@ -13,12 +13,15 @@ information.
    >
    > Required properties:
    > - compatible: should contain the platform identifier such as:
    > + RC mode:
    > "fsl,ls1021a-pcie", "snps,dw-pcie"
    > "fsl,ls2080a-pcie", "fsl,ls2085a-pcie", "snps,dw-pcie"
    > "fsl,ls2088a-pcie"
    > "fsl,ls1088a-pcie"
    > "fsl,ls1046a-pcie"
    > "fsl,ls1012a-pcie"
    > + EP mode:
    > + "fsl,ls-pcie-ep"

    You need SoC specific compatibles for the same reasons as the RC.
    [Xiaowei Bao] I want to contains all layerscape platform use one compatible if the PCIe controller work in EP mode.

    Rob
    \
     
     \ /
      Last update: 2018-10-26 05:46    [W:3.648 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site