Messages in this thread | | | Date | Thu, 25 Oct 2018 16:15:23 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 1/3] mfd: upboard: Add UP2 platform controller driver |
| |
On Thu, Oct 25, 2018 at 12:05:05PM +0100, Lee Jones wrote: > On Sat, 20 Oct 2018, Andy Shevchenko wrote: > > On Fri, Oct 19, 2018 at 8:26 PM Dan O'Donovan <dan@emutex.com> wrote:
> > > + ret = upboard_init_gpio(dev); > > > + if (ret) { > > > + if (ret != -EPROBE_DEFER) > > > + dev_err(dev, "failed to init GPIOs: %d", ret); > > > + return ret; > > > + } > > > > I don't know if probe_err() helper is going to be a part of v4.21 > > (which this series targets), it would be good to use it. > > Interesting. What does it do?
The code will tell better than I https://lore.kernel.org/lkml/20181017132205.5204-1-a.hajda@samsung.com/
-- With Best Regards, Andy Shevchenko
| |