Messages in this thread | | | Date | Thu, 25 Oct 2018 15:08:20 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH] leds: gpio: set led_dat->gpiod pointer for OF defined GPIO leds |
| |
On Tue 2018-10-23 12:18:44, Liviu Dudau wrote: > On Thu, Oct 18, 2018 at 01:14:32AM +0100, Liviu Dudau wrote: > > Commit 45d4c6de4e49 ("leds: gpio: Try to lookup gpiod from device") > > removed the common code path that set the led_dat->gpiod pointer in > > create_gpio_led(), but only added it back for the devices that have > > a valid gpio_led_platform_data structure. Calling gpio_leds_create() > > in gpio_led_probe() is not enough to get a valid gpiod pointer. > > > > Fortunately enough, gpio_leds_create() already gets the needed pointer, > > we just need to assign it to the relevant gpio_led_data structure. > > > > Fixes: 45d4c6de4e49 ("leds: gpio: Try to lookup gpiod from device") > > Cc: Linus Walleij <linus.walleij@linaro.org> > > Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com> > > Signed-off-by: Liviu Dudau <liviu@dudau.co.uk>
Acked-by: Pavel Machek <pavel@ucw.cz>
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |