Messages in this thread | | | Subject | Re: [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver | From | Jianxin Pan <> | Date | Wed, 24 Oct 2018 16:51:27 +0800 |
| |
On 2018/10/24 16:47, Stephen Boyd wrote: > Quoting Jianxin Pan (2018-10-23 23:29:24) >> On 2018/10/19 1:13, Stephen Boyd wrote: >>> Quoting Jianxin Pan (2018-10-17 22:07:25) >> [...] >>>> diff --git a/drivers/clk/meson/mmc-clkc.c b/drivers/clk/meson/mmc-clkc.c >>>> new file mode 100644 >>>> index 0000000..5555e3f >>>> --- /dev/null >>>> +++ b/drivers/clk/meson/mmc-clkc.c >>>> @@ -0,0 +1,296 @@ >>>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) >>>> +/* >>>> + * Amlogic Meson MMC Sub Clock Controller Driver >>>> + * >>>> + * Copyright (c) 2017 Baylibre SAS. >>>> + * Author: Jerome Brunet <jbrunet@baylibre.com> >>>> + * >>>> + * Copyright (c) 2018 Amlogic, inc. >>>> + * Author: Yixun Lan <yixun.lan@amlogic.com> >>>> + */ >>>> + >>>> +#include <linux/clk.h> >>> >>> clk-provider.h instead of clk.h?> >> Maybe we need to keep clk.h >> devm_clk_get() is called in mmc_clkc_register_mux() to get parent in from DTS. >> I'm sorry to miss this in previous reply. > > OK. But also include clk-provider.h if provider APIs are being used > here. OK. I will add it. Thank you. > > . >
| |