lkml.org 
[lkml]   [2018]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] security: fix documentation for the socket_getpeersec_dgram hook
On Tue, Oct 23, 2018 at 4:14 AM,  <efremov@linux.com> wrote:
> From: Denis Efremov <efremov@linux.com>
>
> The socket_getpeersec_dgram hook was changed in the commit
> "[AF_UNIX]: Kernel memory leak fix for af_unix datagram getpeersec patch"
> (dc49c1f94e34). The arguments @secdata and @seclen were changed to @sock
> and @secid. This patch updates the documentation accordingly.
>
> Signed-off-by: Denis Efremov <efremov@linux.com>

Reviewed-by: Kees Cook <keescook@chromium.org>

-Kees

> ---
> include/linux/lsm_hooks.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/lsm_hooks.h b/include/linux/lsm_hooks.h
> index ae3766720264..a598e601ccb3 100644
> --- a/include/linux/lsm_hooks.h
> +++ b/include/linux/lsm_hooks.h
> @@ -861,9 +861,9 @@
> * the IP_PASSSEC option via getsockopt. It can then retrieve the
> * security state returned by this hook for a packet via the SCM_SECURITY
> * ancillary message type.
> - * @skb is the skbuff for the packet being queried
> - * @secdata is a pointer to a buffer in which to copy the security data
> - * @seclen is the maximum length for @secdata
> + * @sock contains the socket structure.
> + * @skb is the skbuff for the packet being queried.
> + * @secid: pointer to where to put the secid of the packet.
> * Return 0 on success, error on failure.
> * @sk_alloc_security:
> * Allocate and attach a security structure to the sk->sk_security field,
> --
> 2.17.2
>



--
Kees Cook

\
 
 \ /
  Last update: 2018-10-23 21:29    [W:0.028 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site