Messages in this thread | | | Subject | Re: [PATCH v2 0/3] tracing: Fix synthetic event parser | From | Tom Zanussi <> | Date | Mon, 22 Oct 2018 15:10:06 -0500 |
| |
Hi Masami,
Sorry for the late reply on this - was out on vacation last week.
On Thu, 2018-10-18 at 22:11 +0900, Masami Hiramatsu wrote: > Hi, > > Here are 2 fixes for synthetic event parser and its testcase. > One bug is that the synthetic_events can not accept "unsigned" > modifier for the field type, and another one is not allowing > the last independent semicolon. > > I found that there is no testcase for checking it too. So the > last patch in this series adding a testcase for synthetic > event parser. >
These patches look good to me, so for the lot:
Acked-by: Tom Zanussi <zanussi@linux.intel.com> Tested-by: Tom Zanussi <zanussi@linux.intel.com>
Thanks,
Tom
> Thank you, > > --- > > Masami Hiramatsu (3): > tracing: Fix synthetic event to accept unsigned modifier > tracing: Fix synthetic event to allow semicolon at end > selftests: ftrace: Add synthetic event syntax testcase > > > kernel/trace/trace_events_hist.c | 32 ++++++-- > .../inter-event/trigger-synthetic-event-syntax.tc | 80 > ++++++++++++++++++++ > 2 files changed, 105 insertions(+), 7 deletions(-) > create mode 100644 > tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger- > synthetic-event-syntax.tc > > -- > Masami Hiramatsu (Linaro) <mhiramat@kernel.org>
| |