Messages in this thread | | | From | "Winkler, Tomas" <> | Subject | RE: [PATCH v7 00/21] tpm: separate tpm 1.x and tpm 2.x commands | Date | Tue, 23 Oct 2018 13:35:29 +0000 |
| |
> > On Mon, 22 Oct 2018, Winkler, Tomas wrote: > >> This is the list of patches (assuming that I didn't miss anything) > >> that still need tested-by tags: > > > > Those are just code movements, we are running them form months on our > > systems. > > I'm not sure what point you are trying to make. You cannot give tested-by by > yourself to yourself you know. By saying that you are just saying things. It is > not any form of peer testing. No, you are exposed to that code base as well, after all you are working @intel. > > >> - tpm: factor out tpm1_get_random into tpm1-cmd.c > >> - tpm: factor out tpm 1.x pm suspend flow into tpm1-cmd.c > >> - tpm1: rename tpm1_pcr_read_dev to tpm1_pcr_read() > >> (the subsystem tag is wrong in this, just noticed, should be > >> 'tpm:') > > When have you established this requirement I missed that and it cannot > > be deduced from the git history. > > Which requirement?
The requirement that the subsystem prefix should be 'tpm:'
Thanks Tomas
| |