lkml.org 
[lkml]   [2018]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] DRM: UDL: get rid of useless vblank initialization
Date
Hi David,

Maybe you have any comments or remarks about this patch?
And if you don't could you please apply it. Thanks!

On Fri, 2018-09-28 at 17:41 +0300, Eugeniy Paltsev wrote:
> UDL doesn't support vblank functionality so we don't need to
> initialize vblank here (we are able to send page flip
> completion events even without vblank initialization)
>
> Moreover current drm_vblank_init call with num_crtcs > 0 causes
> sending DRM_EVENT_FLIP_COMPLETE event with zero timestamp every
> time. This breaks userspace apps (for example weston) which
> relies on timestamp value.
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: stable@vger.kernel.org
> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
> ---
> drivers/gpu/drm/udl/udl_main.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/udl/udl_main.c b/drivers/gpu/drm/udl/udl_main.c
> index f455f095a146..1b014d92855b 100644
> --- a/drivers/gpu/drm/udl/udl_main.c
> +++ b/drivers/gpu/drm/udl/udl_main.c
> @@ -350,15 +350,10 @@ int udl_driver_load(struct drm_device *dev, unsigned long flags)
> if (ret)
> goto err;
>
> - ret = drm_vblank_init(dev, 1);
> - if (ret)
> - goto err_fb;
> -
> drm_kms_helper_poll_init(dev);
>
> return 0;
> -err_fb:
> - udl_fbdev_cleanup(dev);
> +
> err:
> if (udl->urbs.count)
> udl_free_urb_list(dev);
--
Eugeniy Paltsev
\
 
 \ /
  Last update: 2018-10-23 13:02    [W:0.042 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site