lkml.org 
[lkml]   [2018]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 2/2] x86/hyperv: make HvNotifyLongSpinWait hypercall
On 18-10-23 10:51:27, Peter Zijlstra wrote:
> On Tue, Oct 23, 2018 at 10:57:40AM +0800, Yi Sun wrote:
> > On 18-10-22 19:15:16, Peter Zijlstra wrote:
>
> > > > >>>> +#if defined(CONFIG_X86_64) && defined(CONFIG_PARAVIRT_SPINLOCKS) && IS_ENABLED(CONFIG_HYPERV)
> > > > >>>> + if (!hv_notify_long_spin_wait(SPIN_THRESHOLD - loop))
> > > > >>>> + break;
> > > > >>>> +#endif
> > >
> > > Secondly; how come you thought that was acceptable in any way shape or
> > > form?
> > >
> > Sorry for that. Will try another way.
>
> Can you try and explain why vcpu_is_preempted() doesn't work for you?

I thought HvSpinWaitInfo is used to notify hypervisor the spin number
which is different with vcpu_is_preempted. So I did not consider
vcpu_is_preempted.

But HvSpinWaitInfo is a quite simple function and could be combined
with vcpu_is_preempted together. So I think it is OK to use
vcpu_is_preempted to make codes clean. I will have a try.

\
 
 \ /
  Last update: 2018-10-23 11:36    [W:0.066 / U:1.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site