Messages in this thread | | | Subject | Re: [PATCH v2 1/5] x86/vdso: Renames variable to fix shadow warning. | From | Andy Lutomirski <> | Date | Mon, 22 Oct 2018 19:13:53 -0700 |
| |
> On Oct 22, 2018, at 6:10 PM, Leonardo Brás <leobras.c@gmail.com> wrote: > > Renames the char variable to avoid shadowing a variable previously > declared on this function.
How about “The go32() and go64() functions has an argument and a local variable called ‘name’. Rename both to clarify the code and to fix a warning with -Wshadow.”
Other than that, Acked-by: Andy Lutomirski <luto@kernel.org>
Ingo or Thomas, it probably makes sense to just apply this to tip:x86/vdso, since it’s an improvement regardless of the fate of the rest of the series.
| |