lkml.org 
[lkml]   [2018]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] pinctrl: intel: pinctrl-baytrail: simplify getting .driver_data
On Sun, Oct 21, 2018 at 10:00:27PM +0200, Wolfram Sang wrote:
> We should get 'driver_data' from 'struct device' directly. Going via
> platform_device is an unneeded step back and forth.
>

Thanks!

I see only 3 out of 5 patches.

Since we are about to establish a separate tree as well as an additional record
in MAINTAINERS data base for Intel pinctrl driver, I ask you to resend only
Intel related stuff in a separate series.

> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Build tested only. buildbot is happy.
>
> drivers/pinctrl/intel/pinctrl-baytrail.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c
> index 6d1a43c0c251..a1c2548123a1 100644
> --- a/drivers/pinctrl/intel/pinctrl-baytrail.c
> +++ b/drivers/pinctrl/intel/pinctrl-baytrail.c
> @@ -1838,8 +1838,7 @@ static int byt_pinctrl_probe(struct platform_device *pdev)
> #ifdef CONFIG_PM_SLEEP
> static int byt_gpio_suspend(struct device *dev)
> {
> - struct platform_device *pdev = to_platform_device(dev);
> - struct byt_gpio *vg = platform_get_drvdata(pdev);
> + struct byt_gpio *vg = dev_get_drvdata(dev);
> int i;
>
> for (i = 0; i < vg->soc_data->npins; i++) {
> @@ -1867,8 +1866,7 @@ static int byt_gpio_suspend(struct device *dev)
>
> static int byt_gpio_resume(struct device *dev)
> {
> - struct platform_device *pdev = to_platform_device(dev);
> - struct byt_gpio *vg = platform_get_drvdata(pdev);
> + struct byt_gpio *vg = dev_get_drvdata(dev);
> int i;
>
> for (i = 0; i < vg->soc_data->npins; i++) {
> --
> 2.19.0
>

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2018-10-21 23:21    [W:0.106 / U:0.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site